Skip to content

Conversation

@pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented Jul 23, 2025

Summary

This goes along with the MDN content PR by @Josh-Cena.

Test results and supporting details

For Firefox 141 and Chrome 134 these are supported:

  • javascript.builtins.AsyncDisposableStack.@@asyncDispose
  • javascript.builtins.AsyncIterator.@@asyncDispose
  • javascript.builtins.DisposableStack.@@dispose
  • javascript.builtins.Iterator.@@dispose
  • javascript.builtins.SuppressedError.error
  • javascript.builtins.SuppressedError.suppressed

Related issues

@github-actions github-actions bot added data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:m [PR only] 25-100 LoC changed labels Jul 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 23, 2025

Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs).

@pepelsbey
Copy link
Member Author

@Josh-Cena, could you please have a quick look if everything is in order here? All features you have documented are present, and the links to the spec are correct. Thanks!

@Elchi3 I was hoping to get the support data for the new features from the collector run if possible. Could you please help with that? Thank you.

@Elchi3
Copy link
Member

Elchi3 commented Jul 24, 2025

Unfortunately, the collector doesn't yet know automatically about things coming from ECMAScript proposals (tracked in openwebdocs/mdn-bcd-collector#893). I opened openwebdocs/mdn-bcd-collector#2589 for the missing pieces.

@Josh-Cena
Copy link
Member

Stuff here look pretty good to me

@Elchi3
Copy link
Member

Elchi3 commented Jul 29, 2025

For Firefox 141 and Chrome 134 these are supported:

  • javascript.builtins.AsyncDisposableStack.@@asyncDispose
  • javascript.builtins.AsyncIterator.@@asyncDispose
  • javascript.builtins.DisposableStack.@@dispose
  • javascript.builtins.Iterator.@@dispose

No support in any browser so you shouldn't add these.

  • javascript.builtins.SuppressedError.error
  • javascript.builtins.SuppressedError.suppressed

@Josh-Cena
Copy link
Member

It's not possible for ERM to be supported without the two properties you mentioned

image

@Elchi3
Copy link
Member

Elchi3 commented Jul 29, 2025

It's not possible for ERM to be supported without the two properties you mentioned

Ah thanks, then the collector tests I added are wrong. Will look into it.

To move this PR forward, I would then assume same support for the new entries you're adding.

@pepelsbey
Copy link
Member Author

To move this PR forward, I would then assume same support for the new entries you're adding.

Thank you!

@github-actions github-actions bot added size:l [PR only] 101-1000 LoC changed and removed size:m [PR only] 25-100 LoC changed labels Jul 29, 2025
@pepelsbey pepelsbey force-pushed the explicit-resource-management branch from 28a21ee to 729d7e7 Compare July 29, 2025 14:18
@pepelsbey pepelsbey marked this pull request as ready for review July 29, 2025 14:21
@pepelsbey pepelsbey requested a review from Elchi3 July 29, 2025 14:22
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript size:l [PR only] 101-1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants