Clarify notes for Safari setHTMLUnsafe() and friends
#27522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api
Elchi3
approved these changes
Aug 6, 2025
Member
Elchi3
left a comment
Elchi3
left a comment
There was a problem hiding this comment.
Reads better to me, thanks Daniel 👍
@lukewarlow, thoughts?
Contributor
|
LGTM |
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
Contributor
Author
|
Actually, I goofed here. As I was trying to write an explanation, I found it only affects parsed HTML within |
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The existing text doesn't actually say what the problem is, just that it "won't work." This PR attempts to add some substance to "won't work."
Test results and supporting details
I encountered this in web-platform-dx/web-features#3200, where the note text wasn't helpful in understanding whether there ought to be a Baseline regression and I had to read the complete bug anyway.
Related issues