devtools as optional permission #27282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Content:Other
rebloor
changed the title
Contributor
Rob--W
requested changes
Jun 23, 2023
files/en-us/mozilla/add-ons/webextensions/api/devtools/index.md
Outdated
Show resolved
Hide resolved
files/en-us/mozilla/add-ons/webextensions/manifest.json/permissions/index.md
Outdated
Show resolved
Hide resolved
Rob--W
approved these changes
Jun 26, 2023
files/en-us/mozilla/add-ons/webextensions/api/devtools/index.md
Outdated
Show resolved
Hide resolved
| {{AddonSidebar}} | ||
|
|
||
| > **Note:** This page describes devtools APIs as they exist in Firefox 55. Although the APIs are based on the [Chrome devtools APIs](https://developer.chrome.com/docs/extensions/mv3/devtools/), there are still many features that are not yet implemented in Firefox, and therefore are not documented here. To see which features are currently missing please see [Limitations of the devtools APIs](#limitations_of_the_devtools_apis). | ||
| > **Note:** This page describes the devtools APIs in Firefox 55. Although the APIs are based on the [Chrome devtools APIs](https://developer.chrome.com/docs/extensions/mv3/devtools/), Firefox does not implement all those features; therefore, not all features are documented here. To see which features are missing, refer to [Limitations of the devtools APIs](#limitations_of_the_devtools_apis). |
Member
There was a problem hiding this comment.
This document mentions Firefox 54/55, which is ages ago. Could you remove the version specific mentions from this article in a follow-up (separate PR so that these can be reviewed independently)?
Member
There was a problem hiding this comment.
@rebloor it looks like this PR is basically ready to be merged, but I noticed the mention to Firefox 55 has not been removed, do we want to remove it by updating this PR before merging it or in a separate PR?
Contributor
Author
files/en-us/mozilla/add-ons/webextensions/extending_the_developer_tools/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Rob Wu <[email protected]>
Member
|
@rebloor Why was this closed without merging? |
Contributor
Author
|
@Rob--W by accident |
github-actions
bot
added
Content:Firefox
Member
|
Hi, looks like we're ready to land this one, shall I merge when CI is done? |
rpl
approved these changes
Aug 10, 2023
| {{AddonSidebar}} | ||
|
|
||
| > **Note:** This page describes devtools APIs as they exist in Firefox 55. Although the APIs are based on the [Chrome devtools APIs](https://developer.chrome.com/docs/extensions/mv3/devtools/), there are still many features that are not yet implemented in Firefox, and therefore are not documented here. To see which features are currently missing please see [Limitations of the devtools APIs](#limitations_of_the_devtools_apis). | ||
| > **Note:** This page describes the devtools APIs in Firefox 55. Although the APIs are based on the [Chrome devtools APIs](https://developer.chrome.com/docs/extensions/mv3/devtools/), Firefox does not implement all those features; therefore, not all features are documented here. To see which features are missing, refer to [Limitations of the devtools APIs](#limitations_of_the_devtools_apis). |
Member
There was a problem hiding this comment.
@rebloor it looks like this PR is basically ready to be merged, but I noticed the mention to Firefox 55 has not been removed, do we want to remove it by updating this PR before merging it or in a separate PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses the documentation needs of Bug 1606862 Make devtools an optional permission.