-
Notifications
You must be signed in to change notification settings - Fork 23k
Sync with fetch spec for Forbidden request header #38296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview URLs (166 pages)
Flaws (446)Note! 21 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
TRUNCATED! |
|
This is wrong because for example https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Permissions-Policy is a response header, but you added "Forbidden request header: yes", which makes no sense. The table says
A "Response header" can't be a "Forbidden request header" because it's not a "Request header". Permissions-Policy is also a special case because it's actually not a forbidden request header according to the spec and Chrome's source code, which is why I ended up reading its article, but you did this for a lot of headers so I'm pretty sure it's wrong for other headers too. |
|
@verhovsky This PR makes no changes wrt correctness. The fetch spec renamed "forbidden header name" to forbidden request header", but both of these terms describe request headers, before and after. So the content was already incorrect before this PR. |
|
The fetch spec says "forbidden request headers" and "forbidden response headers". A response is not called an "after-request" anywhere. Calling |
|
"Forbidden header name" has always meant "forbidden request header" in the fetch spec, despite its confusing name. The original content is as wrong as the current content. |
|
FWIW in #41938 I modified the Permissions-Policy to "Forbidden Response Header" value of "no" based on ttps://fetch.spec.whatwg.org/#forbidden-response-header-name |
Fix #22502.
whatwg/fetch#1541 changes both the terminology and its definition. This PR makes docs in sync with latest spec.