-
Notifications
You must be signed in to change notification settings - Fork 23k
docs: add ResourceType.json
#38305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add ResourceType.json
#38305
Conversation
|
Preview URLs
(comment last updated: 2025-02-28 22:04:34) |
files/en-us/mozilla/add-ons/webextensions/api/declarativenetrequest/resourcetype/index.md
Outdated
Show resolved
Hide resolved
|
@seia-soto thanks for picking up this change. This should also have an entry in the release notes and an update made to the BCD. |
|
@rebloor Thanks for picking up the places. For browser compatibility data, I already put the issue here: mdn/browser-compat-data#26016. However, I couldn't verify the request type existence so far on Firefox. I tried to trigger JSON module import by using both static and dynamic form, but both of I expect this will be settled with import attribution (and here's a direct URL to the corresponding Firefox meta issue) by looking at this test code. For Chromium, they also don't ship it yet and it looks like nothing decided in this Chromium issue. I'll update this pull as the situation changes. |
|
@dotproto know anything about this? |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Sorry for the late reply. The "json" resource type is new to me, but happy to help chase down info. I haven't tried myself, but I think this feature should now work as expected in Firefox Nightly. Seems mdn/browser-compat-data#26016 was closed as the feature behind the introduction of the "json" value wasn't supported. It seems the flag is being default enabled in Firefox 138, so we should be able to revisit that shortly. Also, I've added a question to the BCD ticket to clarify my understanding of the availability requirement for future reference. |
|
Preview URLs
Flaws (1)Note! 2 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (2)URL:
(comment last updated: 2025-05-05 08:11:35) |
|
@seia-soto we also need release notes, which are made on source/firefox/138 |
refs mozilla/gecko-dev@e6a7800 refs https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/toolkit/components/extensions/schemas/web_request.json refs https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/toolkit/components/extensions/schemas/declarative_net_request.json
For both `declarativeNetRequest` and `webRequest`.
ec784e9 to
dbb88a6
Compare
|
This pull request has merge conflicts that must be resolved before it can be merged. |
|
@rebloor release note updated.
|
rebloor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @seia-soto
Description
This adds the type of
jsoninResourceTypefromwebRequest.ResourceTypeanddeclarativeNetRequest.ResourceType.Motivation
This reflects the latest changes from Firefox source code.
jsonis pretty broad word to use without details.Note that it looks like not released yet, so I don't know if this is okay to go now.
Additional details
refs mozilla/gecko-dev@e6a7800
refs https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/toolkit/components/extensions/schemas/web_request.json
refs https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/toolkit/components/extensions/schemas/declarative_net_request.json
refs https://bugzilla.mozilla.org/show_bug.cgi?id=1858078
Related issues and pull requests