-
Notifications
You must be signed in to change notification settings - Fork 23k
Restructure the scripting test your skills navigation #40634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure the scripting test your skills navigation #40634
Conversation
| --- | ||
| title: "Test your skills: JavaScript" | ||
| short-title: Test your skills | ||
| short-title: Test your skills index |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided on a format like
| short-title: Test your skills index | |
| short-title: Test: JavaScript test index |
hamishwillee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, the index short title has been updated; still waiting for feedback from the team about which icon to use.
I agree, but I think this is another compromise we might have to live with. It does feel weird that it is not in the prev/next chain, but I think it might feel even weirder to force the user to revisit all the tests that they have previously seen earlier in the chain. Unless we phrase using some kind of language like "Next up, you'll be directed to the index for all the JavaScript tests, so you can revisit any that you feel you need a bit more practice on"...but, hrm, I'm not sure. |
|
@hamishwillee can I get an approval on this one too? ;-) |
hamishwillee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes :-)
* Restructure the scripting test your skills navigation * Update skill tests index short title for consistency

Description
This PR restructures the Learning area scripting module "test your skills" navigation, in the same way as #40503 did for the a11y module.
See the linked PR for more information on motivation, etc.
Motivation
Additional details
Related issues and pull requests