Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Aug 5, 2025

Description

This PR restructures the Learning area scripting module "test your skills" navigation, in the same way as #40503 did for the a11y module.

See the linked PR for more information on motivation, etc.

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested review from a team as code owners August 5, 2025 08:16
@chrisdavidmills chrisdavidmills requested review from hamishwillee and pepelsbey and removed request for a team August 5, 2025 08:16
@github-actions github-actions bot added the Content:Learn Learning area docs label Aug 5, 2025
@chrisdavidmills chrisdavidmills requested a review from bsmth August 5, 2025 08:16
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2025

Preview URLs (29 pages)
Flaws (1)

Note! 28 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Core/Scripting/Debugging_JavaScript
Title: JavaScript debugging and error handling
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/API/console/error which is a redirect
External URLs (1)

URL: /en-US/docs/Learn_web_development/Core/Scripting/Test_your_skills/Variables
Title: Test your skills: Variables

(comment last updated: 2025-08-11 08:09:21)

---
title: "Test your skills: JavaScript"
short-title: Test your skills
short-title: Test your skills index
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We decided on a format like

Suggested change
short-title: Test your skills index
short-title: Test: JavaScript test index

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Note change in sidebar title for the index. Still needs the icon for tests.

FYI This transition doesn't go to the index. Feels a bit odd as you're following the next/back path.

image

@chrisdavidmills
Copy link
Contributor Author

chrisdavidmills commented Aug 11, 2025

Looks good. Note change in sidebar title for the index. Still needs the icon for tests.

OK, the index short title has been updated; still waiting for feedback from the team about which icon to use.

FYI This transition doesn't go to the index. Feels a bit odd as you're following the next/back path.

I agree, but I think this is another compromise we might have to live with. It does feel weird that it is not in the prev/next chain, but I think it might feel even weirder to force the user to revisit all the tests that they have previously seen earlier in the chain.

Unless we phrase using some kind of language like "Next up, you'll be directed to the index for all the JavaScript tests, so you can revisit any that you feel you need a bit more practice on"...but, hrm, I'm not sure.

@chrisdavidmills
Copy link
Contributor Author

@hamishwillee can I get an approval on this one too? ;-)

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-)

@chrisdavidmills chrisdavidmills merged commit 9d3d642 into mdn:main Aug 18, 2025
8 checks passed
@chrisdavidmills chrisdavidmills deleted the restructure-scripting-test-your-skills-nav branch August 18, 2025 09:25
estelle pushed a commit that referenced this pull request Aug 19, 2025
* Restructure the scripting test your skills navigation

* Update skill tests index short title for consistency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants