Skip to content

Conversation

@dletorey
Copy link
Contributor

@dletorey dletorey commented Aug 6, 2025

Description

  • Created page for :heading pseudo-class
  • Created page for :heading() functional pseudo-class
  • Added both to the pseudo-classes page

Motivation

Related issues and pull requests

@dletorey dletorey requested a review from a team as a code owner August 6, 2025 11:16
@dletorey dletorey requested review from estelle and removed request for a team August 6, 2025 11:16
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Aug 6, 2025
@dletorey dletorey requested review from bsmth and dipikabh and removed request for estelle August 6, 2025 11:17
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Aug 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2025

Preview URLs

Flaws (2)

Note! 2 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/Pseudo-classes
Title: Pseudo-classes
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/CSS/:active-view-transition-type
    • Can't resolve /en-US/docs/Web/CSS/:active-view-transition-type

(comment last updated: 2025-08-18 10:31:20)

dletorey and others added 4 commits August 6, 2025 12:19
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dletorey, great stuff!
I've added some suggestions for improving clarity and filling some gaps.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dletorey dletorey requested a review from dipikabh August 11, 2025 14:43
@keithamus keithamus mentioned this pull request Aug 14, 2025
3 tasks
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, @dletorey. Thanks a lot for all the updates.
I've added a few trailing cleanup suggestions, but this is looking ready to land 🎉

@dletorey dletorey merged commit 29033c0 into mdn:main Aug 18, 2025
8 checks passed
@dletorey dletorey deleted the 40483-heading-selectors branch August 18, 2025 10:30
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question regarding the support for aria role of heading

@dletorey dletorey restored the 40483-heading-selectors branch August 18, 2025 14:22
estelle pushed a commit that referenced this pull request Aug 19, 2025
* added the :heading and :heading pages

* finshed the :heading & :heading() pages

* added note to :heading() and added both to pseudo-classes page

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* made explanation match code example

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fixed code blocks

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* updated the Note & parameters

* fixed the syntax example

* added a note about matching attributes

* moved the note to usage notes

* Update files/en-us/web/css/_colon_heading/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

* Update files/en-us/web/css/_colon_heading_function/index.md

Co-authored-by: Dipika Bhattacharya <[email protected]>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants