Skip to content

Conversation

@bsmth
Copy link
Member

@bsmth bsmth commented Aug 20, 2025

Description

Using & inside @scope changes according to spec updates (and relation to :scope).

This makes & & redundant as far as I can see. The explainer has good context and I hope I've conveyed that in these changes.

Explainer: https://css.oddbird.net/scope/parent-selector/

Bugs

Additional details

@bsmth bsmth requested a review from a team as a code owner August 20, 2025 12:50
@bsmth bsmth requested review from chrisdavidmills and removed request for a team August 20, 2025 12:50
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Aug 20, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2025

Preview URLs

Flaws (4)

URL: /en-US/docs/Web/CSS/@scope
Title: @scope
Flaw count: 4

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/scope-start
    • Can't resolve /en-US/docs/Web/CSS/scope-end
    • Can't resolve /en-US/docs/Web/CSS/block-contents
  • macros:
    • Macro produces link /en-US/docs/Learn_web_development/Core/Styling_basics/Cool-looking_box which is a redirect

(comment last updated: 2025-08-28 09:19:54)

@dipikabh
Copy link
Contributor

I can take up the review for this

@dipikabh dipikabh self-requested a review August 26, 2025 16:40
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for capturing the changes in the specificity behavior.
I've added a few rephrasing suggestions.

bsmth and others added 2 commits August 27, 2025 10:21
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Aug 27, 2025
@bsmth bsmth requested a review from dipikabh August 27, 2025 09:03
@bsmth
Copy link
Member Author

bsmth commented Aug 27, 2025

Thanks for the review! @dipikabh do you want to have another look?

Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better after the cleanup, thanks!

@bsmth
Copy link
Member Author

bsmth commented Aug 28, 2025

Thanks, Dipika! Do you want to have another look?

@bsmth bsmth requested a review from dipikabh August 28, 2025 09:18
@dipikabh
Copy link
Contributor

Looks really good, thanks a lot @bsmth!
Let's land these updates 🎉

@bsmth
Copy link
Member Author

bsmth commented Aug 28, 2025

Looks really good, thanks a lot @bsmth! Let's land these updates 🎉

Great, thanks a lot!

@bsmth bsmth merged commit 4708192 into mdn:main Aug 28, 2025
8 checks passed
@bsmth bsmth deleted the 40481-css-ampersand-at-scope-content branch August 28, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants