-
Notifications
You must be signed in to change notification settings - Fork 23k
Update splash page challenge #40878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update splash page challenge #40878
Conversation
|
This fixes #32082 right? |
|
@bsmth OK, this is now updated with the new image info, and ready to review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have "your browser doesn't support" for video and audio, not sure if we want to keep that, still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes. Removed.
files/en-us/learn_web_development/core/structuring_content/splash_page/index.md
Outdated
Show resolved
Hide resolved
|
|
||
| The following screenshot shows what the splash page should look like. If you are getting stuck on how to achieve some of this, see the solution below the live example. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in the sibling dir ../splash_page/finished-splash-example.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure what you mean here. The path is correct.
files/en-us/learn_web_development/core/structuring_content/splash_page/index.md
Outdated
Show resolved
Hide resolved
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small things to fix up, but leaving a +1 for when you've had a look 👍🏻
…ash_page/index.md Co-authored-by: Brian Smith <[email protected]>
…ash_page/index.md Co-authored-by: Brian Smith <[email protected]>
Description
This PR is part of a series in which I update the Learn area "Challenge" articles. In general, they need to be modernized, restructured, and put in better positions in the modules so they are spaced out better and test subjects that have already been covered.
This PR improves the Mozilla splash page challenge. Specifically, it:
Motivation
Additional details
Related issues and pull requests
Fixes #32082