Skip to content

Conversation

@chrisdavidmills
Copy link
Contributor

@chrisdavidmills chrisdavidmills commented Aug 27, 2025

Description

This PR is part of mdn/mdn#605, which sets out the aim of removing embedded learning-area repo examples into regular content. See mdn/mdn#605 (comment) specifically for a list of GH embed macros we want to remove.

This PR removes GH embed macros from the remaining Learn area articles, replacing them with regular live sample embeds.

Note that one GH embed I haven't replaced is the Three.js example in the "Drawing graphics" article. It includes a copy of the Three library, and I wasn't sure how best to include this. We should explore that in a separate PR at some point.
^ done

Motivation

Additional details

Related issues and pull requests

@chrisdavidmills chrisdavidmills requested a review from a team as a code owner August 27, 2025 11:40
@chrisdavidmills chrisdavidmills requested review from bsmth and removed request for a team August 27, 2025 11:40
@github-actions github-actions bot added Content:Learn Learning area docs size/xl [PR only] >1000 LoC changed labels Aug 27, 2025
@chrisdavidmills chrisdavidmills changed the title Fix markdown lint errors Replace GH sample embeds in the remaining Learn area articles Aug 27, 2025
…drawing_graphics/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2025

chrisdavidmills and others added 3 commits August 27, 2025 12:47
…drawing_graphics/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…drawing_graphics/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…drawing_graphics/index.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@bsmth bsmth self-requested a review August 28, 2025 11:59
@bsmth
Copy link
Member

bsmth commented Aug 29, 2025

FYI #40915 is touching similar content, the sintel video is used there, too

@bsmth
Copy link
Member

bsmth commented Aug 29, 2025

Note that one GH embed I haven't replaced is the Three.js example in the "Drawing graphics" article. It includes a copy of the Three library, and I wasn't sure how best to include this.

You can have a look here for an example that does this:

@chrisdavidmills
Copy link
Contributor Author

Note that one GH embed I haven't replaced is the Three.js example in the "Drawing graphics" article. It includes a copy of the Three library, and I wasn't sure how best to include this.

You can have a look here for an example that does this:

Superb, thanks @bsmth! I've followed the same pattern, and it works now, in-page. The one thing missing is the image tile I use in the example. I've added that to the shared-assets repo in mdn/shared-assets#64

@bsmth
Copy link
Member

bsmth commented Sep 1, 2025

Superb, thanks @bsmth! I've followed the same pattern, and it works now, in-page. The one thing missing is the image tile I use in the example. I've added that to the shared-assets repo in mdn/shared-assets#64

Lovely, that's merged now so you can have another look if it works

<source src="video/sintel-short.webm" type="video/webm" />
<!-- fallback content here -->
<source
src="https://mdn.github.io/learning-area/javascript/apis/video-audio/finished/video/sintel-short.mp4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that these are in the shared assets repo already -> https://github.com/mdn/shared-assets/tree/main/videos

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome; I've updated those references too.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I think that's everything from my side! TY

@chrisdavidmills chrisdavidmills merged commit 328ca42 into mdn:main Sep 1, 2025
8 checks passed
@chrisdavidmills chrisdavidmills deleted the replace-testing-and-graphics-gh-sample-embeds branch September 1, 2025 14:24
@chrisdavidmills chrisdavidmills restored the replace-testing-and-graphics-gh-sample-embeds branch September 1, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Learn Learning area docs size/xl [PR only] >1000 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants