-
Notifications
You must be signed in to change notification settings - Fork 23k
Replace GH sample embeds in the remaining Learn area articles #40905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace GH sample embeds in the remaining Learn area articles #40905
Conversation
…drawing_graphics/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/learn_web_development/extensions/client-side_apis/video_and_audio_apis/index.md
Outdated
Show resolved
Hide resolved
|
Preview URLs
External URLs (1)URL:
(comment last updated: 2025-09-01 14:21:40) |
…drawing_graphics/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…drawing_graphics/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…drawing_graphics/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
files/en-us/learn_web_development/extensions/client-side_apis/drawing_graphics/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/client-side_apis/drawing_graphics/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/client-side_apis/drawing_graphics/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/extensions/client-side_apis/drawing_graphics/index.md
Outdated
Show resolved
Hide resolved
|
FYI #40915 is touching similar content, the sintel video is used there, too |
You can have a look here for an example that does this: content/files/en-us/games/techniques/3d_on_the_web/building_up_a_basic_demo_with_three.js/index.md Line 184 in dbf1f82
|
…drawing_graphics/index.md Co-authored-by: Brian Smith <[email protected]>
Superb, thanks @bsmth! I've followed the same pattern, and it works now, in-page. The one thing missing is the image tile I use in the example. I've added that to the shared-assets repo in mdn/shared-assets#64 |
Lovely, that's merged now so you can have another look if it works |
| <source src="video/sintel-short.webm" type="video/webm" /> | ||
| <!-- fallback content here --> | ||
| <source | ||
| src="https://mdn.github.io/learning-area/javascript/apis/video-audio/finished/video/sintel-short.mp4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that these are in the shared assets repo already -> https://github.com/mdn/shared-assets/tree/main/videos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome; I've updated those references too.
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I think that's everything from my side! TY
Description
This PR is part of mdn/mdn#605, which sets out the aim of removing embedded learning-area repo examples into regular content. See mdn/mdn#605 (comment) specifically for a list of GH embed macros we want to remove.
This PR removes GH embed macros from the remaining Learn area articles, replacing them with regular live sample embeds.
Note that one GH embed I haven't replaced is the Three.js example in the "Drawing graphics" article. It includes a copy of the Three library, and I wasn't sure how best to include this. We should explore that in a separate PR at some point.^ done
Motivation
Additional details
Related issues and pull requests