-
Notifications
You must be signed in to change notification settings - Fork 23k
Rewrite DnD guides #40943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite DnD guides #40943
Conversation
d75a661 to
a589dd0
Compare
a589dd0 to
30c0c7c
Compare
30c0c7c to
62a4f53
Compare
|
I am finally looking at this PR. |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I've long been sad about the DnD docs on MDN but never managed to do it, as this PR shows, it's a lot of work.
I thought this was a really excellent explanation though and great examples, it's a massive improvement.
files/en-us/web/api/html_drag_and_drop_api/drag_operations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/html_drag_and_drop_api/drag_operations/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/html_drag_and_drop_api/file_drag_and_drop/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/html_drag_and_drop_api/drag_data_store/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/html_drag_and_drop_api/kanban_board/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/html_drag_and_drop_api/kanban_board/index.md
Outdated
Show resolved
Hide resolved
|
I have bit the bullet and updated the drag data store page to describe exactly what browsers do, which may make it either messier or clearer, I don't know :) |
wbamberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks. Great work!
Notable changes:
I did not fix #27654 the way requested, because DnD in fact does not contain three distinct topics. "In-page DnD" very much uses the same features as dragging in or dragging out, it just happens that there are certain events that don't fire for dragging in or dragging out.