Add a form wrapper for better UX #41304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:Learn
1 task
Contributor
|
Preview URLs (comment last updated: 2025-10-07 15:50:21) |
dipikabh
requested changes
Oct 6, 2025
Contributor
dipikabh
left a comment
dipikabh
left a comment
There was a problem hiding this comment.
Thanks for the improvements!
I've added a few suggestions for you to consider
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
files/en-us/learn_web_development/core/scripting/dom_scripting/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Dipika Bhattacharya <[email protected]>
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. |
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
Co-authored-by: Dipika Bhattacharya <[email protected]>
pepelsbey
requested review from
Copilot and
dipikabh
and removed request for
Copilot
pepelsbey
added a commit
to mdn/learning-area
that referenced
this pull request
Oct 7, 2025
### Description - Adds `<form>` wrapper and `preventDefault` handler - Changes the inline demo and the step-by-step guide to match ### Motivation To have a better UX: pressing Enter in the field now adds an item. Based on the original PR mdn/content#40201 ### Related issues and pull requests - [x] mdn/content#41304⚠️ Should be merged together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
<form>wrapper andpreventDefaulthandlerMotivation
To have a better UX: pressing Enter in the field now adds an item.
Based on the original PR #40201
Related issues and pull requests