Skip to content

Conversation

@Josh-Cena
Copy link
Member

After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now require all non-generic font family names to be quoted, no exceptions—not even "Arial". In addition, I noticed that the weird Arial, Helvetica, sans-serif combination is used a lot—which is pointless because every computer that supports Helvetica is also going to support Arial, so I reordered these two.

@Josh-Cena Josh-Cena requested review from a team as code owners October 11, 2025 03:44
@Josh-Cena Josh-Cena requested review from chrisdavidmills, pepelsbey and wbamberg and removed request for a team October 11, 2025 03:44
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs Content:WebAPI Web API docs Content:JS JavaScript docs Content:Learn Learning area docs Content:SVG SVG docs Content:Media Media docs Content:Firefox Content in the Mozilla/Firefox subtree Content:PWA Progressive Web Apps content labels Oct 11, 2025
@Josh-Cena Josh-Cena requested review from bsmth and removed request for a team, chrisdavidmills, pepelsbey and wbamberg October 11, 2025 03:44
@github-actions github-actions bot added the size/m [PR only] 51-500 LoC changed label Oct 11, 2025
@github-actions
Copy link
Contributor

Preview URLs (53 pages)
Flaws (7)

Note! 49 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Learn_web_development/Extensions/Client-side_APIs/Drawing_graphics
Title: Drawing graphics
Flaw count: 1

  • unknown:
    • Error opening /shared-assets/images/examples/web-animations/cat_sprite.png: No such file or directory (os error 2)

URL: /en-US/docs/Learn_web_development/Extensions/Performance/CSS
Title: CSS performance optimization
Flaw count: 2

  • broken_links:
    • /en-US/docs/Learn_web_development/Extensions/Performance/html is ill cased
    • /en-US/docs/Learn_web_development/Extensions/Performance/html is ill cased

URL: /en-US/docs/Web/API/Web_components/Using_templates_and_slots
Title: Using templates and slots
Flaw count: 3

  • macros:
    • Macro produces link /en-US/docs/Web/Web_Components/Using_custom_elements which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_shadow_DOM which is a redirect
    • Macro produces link /en-US/docs/Web/Web_Components/Using_templates_and_slots which is a redirect

URL: /en-US/docs/Web/SVG/Reference/Element/feMorphology
Title: <feMorphology>
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Web/SVG/Reference/Element/discard which is a redirect

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hamishwillee hamishwillee merged commit 9cfc228 into mdn:main Oct 13, 2025
7 checks passed
@Josh-Cena Josh-Cena deleted the font-family-quotes branch October 13, 2025 00:33
@Josh-Cena
Copy link
Member Author

Thanks for all the reviews!

@hamishwillee
Copy link
Collaborator

You're welcome. Personally if I've done the work, I like to get the PRs off my mental queue as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:HTML Hypertext Markup Language docs Content:JS JavaScript docs Content:Learn Learning area docs Content:Media Media docs Content:PWA Progressive Web Apps content Content:SVG SVG docs Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants