-
Notifications
You must be signed in to change notification settings - Fork 23k
Lint: quote non-generic font-family values (1) #41469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
files/en-us/learn_web_development/core/frameworks_libraries/angular_styling/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/core/frameworks_libraries/react_todo_list_beginning/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/core/styling_basics/handling_conflicts/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/core/text_styling/fundamentals/index.md
Show resolved
Hide resolved
files/en-us/learn_web_development/core/styling_basics/handling_conflicts/index.md
Show resolved
Hide resolved
hamishwillee
approved these changes
Oct 13, 2025
Collaborator
hamishwillee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Member
Author
|
Thanks for all the reviews! |
Collaborator
|
You're welcome. Personally if I've done the work, I like to get the PRs off my mental queue as soon as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Content:Firefox
Content in the Mozilla/Firefox subtree
Content:HTML
Hypertext Markup Language docs
Content:JS
JavaScript docs
Content:Learn
Learning area docs
Content:Media
Media docs
Content:PWA
Progressive Web Apps content
Content:SVG
SVG docs
Content:WebAPI
Web API docs
size/m
[PR only] 51-500 LoC changed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now require all non-generic font family names to be quoted, no exceptions—not even
"Arial". In addition, I noticed that the weirdArial, Helvetica, sans-serifcombination is used a lot—which is pointless because every computer that supports Helvetica is also going to support Arial, so I reordered these two.