Lint: quote non-generic font-family values (3) #41471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
requested review from
bsmth and
estelle
and removed request for
a team and
estelle
github-actions
bot
added
Content:CSS
Contributor
Preview URLs (48 pages)
Flaws (359)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
URL:
|
|
|
||
| @font-palette-values --blue-nabla { | ||
| font-family: Nabla; | ||
| font-family: "Nabla"; |
Collaborator
There was a problem hiding this comment.
The CSS rules recommend a fallback, but don't cover the case where there is no natural fallback. I am therefore assuming things like this are fine.
hamishwillee
approved these changes
Oct 13, 2025
Collaborator
hamishwillee
left a comment
hamishwillee
left a comment
There was a problem hiding this comment.
Thanks very much @Josh-Cena
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #40228, we are a lot more explicit on some CSS stylistic decisions. In particular, we now require all non-generic font family names to be quoted, no exceptions—not even
"Arial". In addition, I noticed that the weirdArial, Helvetica, sans-serifcombination is used a lot—which is pointless because every computer that supports Helvetica is also going to support Arial, so I reordered these two.