Skip to content

Add browser support considerations to code guidelines #41577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hamishwillee merged 1 commit into from
Oct 19, 2025
Merged

Add browser support considerations to code guidelines #41577

hamishwillee merged 1 commit into from
Oct 19, 2025

Conversation

@pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented Oct 17, 2025

Description

Adds browser support considerations to code guidelines:

  • Use feature detection
  • Don’t specify supporting browsers

Motivation

To improve maintenance.

@pepelsbey pepelsbey requested a review from dipikabh October 17, 2025 14:10
@pepelsbey pepelsbey requested a review from a team as a code owner October 17, 2025 14:10
@github-actions github-actions bot added Content:Meta Content in the meta docs size/s [PR only] 6-50 LoC changed labels Oct 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 17, 2025

Preview URLs

Flaws (1)

URL: /en-US/docs/MDN/Writing_guidelines/Code_style_guide
Title: Guidelines for writing code examples
Flaw count: 1

  • broken_links:
    • /en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Feature_detection is a redirect

hamishwillee
hamishwillee approved these changes Oct 19, 2025
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one

@hamishwillee hamishwillee merged commit 3a42aa0 into mdn:main Oct 19, 2025
7 checks passed
@pepelsbey pepelsbey mentioned this pull request Oct 20, 2025
Merged
@pepelsbey pepelsbey deleted the examples-support branch October 20, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@dipikabh dipikabh Awaiting requested review from dipikabh

Assignees

No one assigned

Labels

Content:Meta Content in the meta docs size/s [PR only] 6-50 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pepelsbey @hamishwillee