-
Notifications
You must be signed in to change notification settings - Fork 23k
Insert required empty line in example HTTP message #41955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
Contributor
|
Preview URLs Flaws (3)URL:
|
bsmth
approved these changes
Nov 17, 2025
Member
bsmth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, let's add it here, thanks 👍🏻
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
estelle
pushed a commit
that referenced
this pull request
Nov 18, 2025
Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the description of the example HTTP message a reference is made to an empty line which doesn't exist. Inserting the missing empty line in the example HTTP message shows how the empty line properly terminates the header section as described in the page content.
Motivation
The non-existence of the empty line should be fixed so that users are not confused by it being referred to, yet not being there. This contribution hopefully prevents such confusion.
Additional details
They empty line is mentioned in section 2.1 of RFC9112
I also considered adding "[ empty line ]" or "CRLF" as shown in the RFC but decided not to as a simple empty line is consistent with the next example directly after it, which contains a similar empty line.
Related issues and pull requests
N/A