Await fs.open call
#42137
Merged
Await fs.open call
#42137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node.js's documentation says that `fs.open` returns a `Promise<FileHandle>`, so it needs to be `await`ed here
github-actions
bot
added
Content:JS
github-actions
bot
added
size/s
Josh-Cena
changed the title
fs.open call in an example for AsyncDisposableStack.adoptfs.open call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Node.js's documentation says that
fs.openreturns aPromise<FileHandle>, so it needs to beawaited here.Motivation
To spare readers the pain of wrong documentation.
Additional details