Fix ABSN.start()'s 'duration' parameter description #42282
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since WebAudio/web-audio-api#1681 (in 2018) the `duration` argument is specced [1] as being the duration of the buffer's content to be played, and not necessarily the one of the AudioContext's clock. So if the source node has a `playbackRate` that is not `1`, using this parameter will not be the same as using `stop(duration)`. I based the wordings on the specs text, but I don't mind another formulation altogether. Might also be noted that there is an interop issue here, where on Firefox does follow the specs. I'll open issues to get this sorted out though. [1]: https://webaudio.github.io/web-audio-api/#dom-audiobuffersourcenode-start-when-offset-duration-duration
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Preview URLs (comment last updated: 2025-12-08 08:13:00) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the description of the AudioBufferSourceNode
start()'sdurationparameter so it's not said to be similar to callingstop(duration).Motivation
Since this specs change 1 (in 2018) the
durationargument is specced 2 as being the duration of the buffer's content to be played, and not necessarily the one of the AudioContext's clock. So if the source node has aplaybackRatethat is not1, using this parameter will not be the same as usingstop(duration).Additional details
I based the wordings on the specs text, but I don't mind another formulation altogether.
Might also be noted that there is an interop issue here, where only Firefox does follow the specs. I'll open issues to get this sorted out though.
Related issues and pull requests
N/A