Update warnings about event handler attributes #42347
Open
+17
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the implicit `with` statement wrapping that event handler attributes do, and the issues that come with it
github-actions
bot
added
Content:HTML
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| > [!WARNING] | ||
| > While not visible by calling the `Function.prototype.toString()` method on the handler, event handler attributes will implicitly wrap code inside of 2 `with` statements, and may produce unexpected results. For example: | ||
| > ```html |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| > ```html | |
| > | |
| > ```html |
| > ```html | ||
| > <div onclick="console.log(new URL(location))">Bad Example</div> | ||
| > ``` | ||
| > Essentially becomes: |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| > Essentially becomes: | |
| > | |
| > Essentially becomes: |
| > <div onclick="console.log(new URL(location))">Bad Example</div> | ||
| > ``` | ||
| > Essentially becomes: | ||
| > ```js example-bad |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| > ```js example-bad | |
| > | |
| > ```js example-bad |
Comment on lines
+1443
to
+1444
| > with(this.ownerDocument) { | ||
| > with(this) { |
Contributor
There was a problem hiding this comment.
[mdn-linter] reported by reviewdog 🐶
Suggested change
| > with(this.ownerDocument) { | |
| > with(this) { | |
| > with (this.ownerDocument) { | |
| > with (this) { |
Contributor
|
Preview URLs Flaws (36)URL:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the implicit
withstatement wrapping that event handler attributes do, and the issues that come with itDescription
Mentioned a (lesser known?) feature of event handler attributes
Motivation
Additional details
Related issues and pull requests