Skip to content
This repository was archived by the owner on Oct 17, 2025. It is now read-only.

Conversation

@scottaohara
Copy link
Contributor

per recent changes to hgroup element, reflected in the updated content of the hgroup MDN doc, the try it example needed to be updated as well.

replaced h2 element with p element

per recent changes to `hgroup` element, reflected in the updated content of the [`hgroup`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hgroup) MDN doc, the try it example needed to be updated as well.
@welcome
Copy link

welcome bot commented Jul 21, 2022

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@jasikpark
Copy link

++ for this change, the description below the example describes that a single heading element is permitted, while the current example has two.

image
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/hgroup#try_it

@jasikpark
Copy link

@scottaohara
Copy link
Contributor Author

@estelle per the updates i made to the hgroup article the other day, this example needed to be updated as well. Is there a separate team that reviews changes to this repo?

@estelle
Copy link
Member

estelle commented Jul 28, 2022

@scottaohara The interactive examples are in a separate repo: https://github.com/mdn/interactive-examples.

I am not sure who generally reviewed these. I was added to that repo last week, so have been reviewing a backlog. if you mention me with @estelle, I will see it in my notifications, which I tend to check at least every other day.

Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@estelle estelle merged commit cc9a629 into mdn:main Jul 28, 2022
@welcome
Copy link

welcome bot commented Jul 28, 2022

Congrats on merging your first pull request! 🎉🎉🎉

@estelle
Copy link
Member

estelle commented Jul 28, 2022

i happen to be in there right now, so I'll make the edit.

@estelle estelle mentioned this pull request Jul 28, 2022
@jasikpark
Copy link

woot 🥳

@scottaohara scottaohara deleted the patch-1 branch July 29, 2022 11:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants