Skip to content
This repository was archived by the owner on Aug 26, 2022. It is now read-only.

Conversation

@darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 7, 2012

@lmorchard
Copy link
Contributor

Hmm, one nit I'm seeing:

That last part is of course just how title-slugification works, but it seems like I have to repeat myself and might change the 404'd slug in the URL. And, since that slug presumably came from a link I clicked on, I might change the slug to something different than I started with, and so create a page that doesn't resolve the 404 that I clicked into.

I don't think we should do anything like prevent slug editing if the user really wants to do that, but getting the title populated could help prevent mistakes in creating pages from 404 links.

@lmorchard
Copy link
Contributor

Tests pass, things work fine beyond my nitpick

@darkwing
Copy link
Contributor Author

darkwing commented Jun 7, 2012

Good point Les, updated.

@lmorchard
Copy link
Contributor

Tests still pass, title population works. But, one more nit (sorry!):

Probably a rare case, but this instead should probably be a redirect to CSS

@darkwing
Copy link
Contributor Author

darkwing commented Jun 7, 2012

Added code to remove the trailing slashes and redirect as necessary to prevent unwanted document creations.

@lmorchard
Copy link
Contributor

One more nitpick... I can't find any more nitpicks. Works for me, tests pass.

lmorchard added a commit that referenced this pull request Jun 7, 2012
bug fix 760240 - Change docs/* 404's into redirects to the create page
@lmorchard lmorchard merged commit 0171998 into mdn:master Jun 7, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants