This repository was archived by the owner on Aug 26, 2022. It is now read-only.
bug 1308630, bug 1468271: Fixes for custom Interactive Examples URLs #4936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load the setting for INTERACTIVE_EXAMPLES_BASE from the environment variable INTERACTIVE_EXAMPLES_BASE, not https://interactive-examples.mdn.mozilla.net.
Search for targetOrigin in the performance entries, not the hard-coded production domain name.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some issues when reviewing PR #4935 and getting my Kuma dev environment to talk to a local checkout of https://github.com/mdn/interactive-examples/
INTERACTIVE_EXAMPLES_BASEfrom the environment, this corrects it.INTERACTIVE_EXAMPLES_BASEviamdn.interactiveEditor.editorUrl.