Update font-display example to use correct format #28578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Review requested
in MDN translated-content l10n-zh
HowieHz
requested review from
SphinxKnight,
davbrito,
hochan222,
mfuji09 and
myshov
and removed request for
a team
github-actions
bot
added
l10n-ja
Contributor
Author
|
link mdn/content#40890 |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
leon-win
reviewed
Aug 28, 2025
Member
|
I propose to also bring the path to files to a unified form: I couldn't do it completely with suggestions, but I wanted to show the train of thought using the Russian locale as an example. |
yin1999
reviewed
Aug 29, 2025
Comment on lines
55
to
56
| url(/path/to/fonts/examplefont.woff) format("woff"), | ||
| url(/path/to/fonts/examplefont.eot) format("embedded-opentype"); |
Member
There was a problem hiding this comment.
Suggested change
| url(/path/to/fonts/examplefont.woff) format("woff"), | |
| url(/path/to/fonts/examplefont.eot) format("embedded-opentype"); | |
| url("/path/to/fonts/example-font.woff") format("woff"), | |
| url("/path/to/fonts/example-font.eot") format("embedded-opentype"); |
Contributor
Author
|
mdn/content#40890 has been merged, I will synchronize its changes. @font-face {
font-family: ExampleFont;
src:
url("/path/to/fonts/example-font.woff") format("woff"),
url("/path/to/fonts/example-font.eot") format("embedded-opentype");
font-weight: 400;
font-style: normal;
font-display: fallback;
} |
Member
|
Approve for |
leon-win
approved these changes
Aug 29, 2025
Contributor
Preview URLs (6 pages)Flaws (12)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
|
tristantheb
requested review from
tristantheb
and removed request for
SphinxKnight
JuanVqz
approved these changes
Sep 5, 2025
Member
JuanVqz
left a comment
JuanVqz
left a comment
There was a problem hiding this comment.
Approved for ES docs, cc @Graywolf9
github-project-automation
bot
moved this from Review requested
to Done
in MDN translated-content l10n-zh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update font-display example to use correct format
Motivation
format("eot") ×
format("embedded-opentype") √
Additional details
Related issues and pull requests
Fixes #28577