feat: add hideImageToolbar option to imagePlugin
#571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@jgeppert I think that we should just use the |
Contributor
Author
|
Sure, makes sense to me, i will update it shortly |
This was referenced Sep 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it possible to hide the image toolbar, e.g. when editor is in readOnly mode.
When using the editor to just render documents (e.g. in an application where some users only have viewing capabilities), even with hidden toolbar and read only mode, each image will still show the toolbar (settings + delete icon). Other plugins, like the table, hide their toolbar already when in read only mode. This makes it possible to get to the same state with the image plugin, alternatively, it could also make sense to always hide the toolbar when in read only mode.