Skip to content

Conversation

ChristianMurphy
Copy link
Member

@ChristianMurphy ChristianMurphy commented Jan 24, 2023

This updates the playground, give it a try in the Vercel preview below.

resolves #2061
resolves #2060

@vercel
Copy link

vercel bot commented Jan 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
mdx ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 8:22PM (UTC)

@wooorm
Copy link
Member

wooorm commented Jan 24, 2023

Looks like syntax highlighting doesn’t work: https://mdx-git-fork-christianmurphy-codemirror-6-mdx.vercel.app/playground/ anymore. I see some errors in the console from codemirror too

@ChristianMurphy
Copy link
Member Author

Thanks!
Took a bit to track that down.
Turns out the package lock file needs to be explicitly deduplicated when updating codemirror to ensure all the packages land on compatible versions.

@ChristianMurphy
Copy link
Member Author

Well, good news it fixed the site. 🎉
Bad news, it turned up a conflict between https://github.com/syntax-tree/estree-util-to-js/releases/tag/1.1.1 and vFile
and some changes to uvu and esbuild which appear to break us 😅

@ChristianMurphy
Copy link
Member Author

ChristianMurphy commented Feb 7, 2023

With a bit of lockfile surgery both the website and tests look happy.
Instead of a general npm upgrade, it uses npm update {individual codemirror package names} followed by npm dedupe.

@wooorm wooorm changed the title migrate website to codemirror 6 and rodemirror 2 Update site dependencies Feb 8, 2023
@wooorm wooorm merged commit b85947b into mdx-js:main Feb 8, 2023
@wooorm wooorm added 📦 area/deps This affects dependencies 💪 phase/solved Post is done 🕸 area/website This affects the website labels Feb 8, 2023
@wooorm
Copy link
Member

wooorm commented Feb 8, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 area/deps This affects dependencies 🕸 area/website This affects the website 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

2 participants