Added shasum for Raspberry Pi binary to attributes/default.rb #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installing from a binary was failing on a Raspberry Pi due to a null string error. I added the shasum to the attributes/default.rb file. However, I used the shasum that I calculated locally. This is wrong. I tried to go to http://nodejs.org/dist/v0.10.15/ and get the shasum posted there from the gpg or asc file, however none of those checksum files, include the necessary checksum for the "arm-pi" flavor of NodeJS. In the absence of an official shasum, can someone find out how to get the tarball over https and confirm the shasum above before merging this pull request? I pulled the tarball over http and therefore my shasum should be treated as suspect until independently verified. In the meantime, I filed an issue over in the joyent/node repo: nodejs/node-v0.x-archive#6338
mdxp
added a commit
that referenced
this pull request
Mar 4, 2014
Added shasum for Raspberry Pi binary to attributes/default.rb
Owner
|
Merged! Thanks @malandrew! |
JenRed12
pushed a commit
to Tealium/nodejs-cookbook
that referenced
this pull request
Jun 11, 2015
Removed install_not_needed? method from nodejs_helper.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing from a binary was failing on a Raspberry Pi due to a null string error. I added the shasum to the attributes/default.rb file. However, I used the shasum that I calculated locally. This is wrong. I tried to go to http://nodejs.org/dist/v0.10.15/ and get the shasum posted there from the gpg or asc file, however none of those checksum files, include the necessary checksum for the "arm-pi" flavor of NodeJS.
In the absence of an official shasum, can someone find out how to get the tarball over https and confirm the shasum above before merging this pull request? I pulled the tarball over http and therefore my shasum should be treated as suspect until independently verified. In the meantime, I filed an issue over in the joyent/node repo:
nodejs/node-v0.x-archive#6338