Remove illuminate #190
Closed
Remove illuminate #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunoocasali
force-pushed
the
remove-illuminati
branch
from
5d83bc4 to
9e13ca4
Compare
brunoocasali
force-pushed
the
remove-illuminati
branch
from
9e13ca4 to
0334ebe
Compare
bors bot
added a commit
that referenced
this pull request
Oct 27, 2022
203: Drop illuminate/collections r=brunoocasali a=norkunas # Pull Request ## Related issue Fixes #184 ## What does this PR do? - Continues work from #190 I've extracted all necessary methods to a custom Collection class not to break any test. At least the dropped dependency now won't block other dependencies to update in apps. ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Co-authored-by: Tomas <[email protected]>
|
Closed by #203 |
bors bot
added a commit
that referenced
this pull request
Oct 31, 2022
205: Update version for the next release (v0.8.2) r=brunoocasali a=brunoocasali This version removes illuminate dependency 🎉 #190 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #<issue_number>
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!