-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Fix: Changed keyword from assisstant to secretary #2937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@prateekchhikara Can you pls review this PR which solves the issue #2636 |
Hey @V-Silpin Can you please sign the CLA contract? |
@Dev-Khant I have completed signing the CLA contract |
@Dev-Khant can you pls review & merge the code |
@Dev-Khant can you pls merge this PR, all the corrections are done. Merging this PR will resolve this issue #2636 |
@V-Silpin, thanks for raising the PR. Could you please update the PR description to include the issue and its fix? |
@prateekchhikara I have updated the PR description, mentioned the issue & the fix Kindly merge this PR |
@prateekchhikara any issues with the PR? |
Pls merge this PR, as we need this issue #2636 to be solved urgently |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, can you please rebase with main
, add a test for this and also run the formatting with pre-commit
? Once the CI tests pass we can merge this.
@Dev-Khant I have added a testcase, done rebase & pre-commit. Kindly review it. |
Hey @V-Silpin There are few merge conflicts can you please resolve it? |
@Dev-Khant Merge Conflict Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, looks good to me.
Description
This PR fixes the issue of content policy trigger bug in Azure OpenAI LLM. The actual cause of this trigger was a keyword "assistant". So I have added some code which replaces the keyword to "secretary " in the user prompt in
azure_openai.py
andazure_openai_structured.py
. By changing the keyword the Memory.add function is working properly, hence fixing the bug.Fixes #2636
Type of change
How Has This Been Tested?
Test Script
Checklist:
Maintainer Checklist