-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Enhance documentation: Add group chat feature to the list of platform… #3077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… features in docs.json
"id": "147559a8-c5f7-44d0-9418-91f53f7a89a4", | ||
"memory": "suggests considering Angular because it has great enterprise support", | ||
"user_id": "charlie", | ||
"session_id": "GroupChat_1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you do not have to show all the fields in the output, only show the important ones - created_at, updated_at, etc. can be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix this issue of fields like internal_metadata
and deleted_at
showing up.
Also, I am not sure @chaithanyak42 if the field here should be run_id
instead of session_id
. Want to keep it consistent across.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey it's being returned as session_ID itself during the search api call - will address
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some minor comments. Thanks!
… features in docs.json
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Please delete options that are not relevant.
Checklist:
Maintainer Checklist