Skip to content

Conversation

andy-k-improving
Copy link
Contributor

@andy-k-improving andy-k-improving commented Jul 24, 2025

Description

This PR aims to fix what described over #3156 , to patch all insert / update queries for Neptune Analytics integration, to guarantee fields: created and updated are always present if applicable and accurate.

Fixes # (issue)

#3156

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Please delete options that are not relevant.

  • Unit Test
  • Test Script (please provide)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Made sure Checks passed

@CLAassistant
Copy link

CLAassistant commented Jul 24, 2025

CLA assistant check
All committers have signed the CLA.

@parshvadaftari
Copy link
Contributor

@andy-k-improving Can you fix the failing test?

Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
Signed-off-by: Andy Kwok <[email protected]>
@andy-k-improving
Copy link
Contributor Author

@parshvadaftari I have cross checked with the CI from main branch, this seems to be an error caused by other commits and now being resolved.
I have rebase my branch for this purpose, would you mind to author build?
It should work this time.

@parshvadaftari
Copy link
Contributor

@andy-k-improving Try merging with main and pushing those changes. This will resolve the failing tests issue.

@andy-k-improving
Copy link
Contributor Author

@andy-k-improving Try merging with main and pushing those changes. This will resolve the failing tests issue.

Thanks the build is green now!

@parshvadaftari parshvadaftari merged commit d523070 into mem0ai:main Aug 23, 2025
6 of 7 checks passed
Echo0ff pushed a commit to Echo0ff/mem0 that referenced this pull request Aug 25, 2025
acarbonetto pushed a commit to acarbonetto/mem0 that referenced this pull request Sep 2, 2025
thestumonkey pushed a commit to thestumonkey/mem0 that referenced this pull request Sep 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants