forked from mdn/content
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from mdn:main #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add challenge to test media, form, and table styling * Update image URLs and add licensing note * Update files/en-us/learn_web_development/core/styling_basics/home_color_scheme_search/index.md Co-authored-by: Hamish Willee <[email protected]> * Update files/en-us/learn_web_development/core/styling_basics/home_color_scheme_search/index.md Co-authored-by: Hamish Willee <[email protected]> * Add comment for background-color step * Make solution comment more intuitive * Remove numbers and make the solution comments match the challenge headings * Increase height of live samples --------- Co-authored-by: Hamish Willee <[email protected]>
* Clarify descriptions of CSS dimension data types * Apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> --------- Co-authored-by: Chris Mills <[email protected]>
* Fixed hyphenation. * Fixed commas; added hyperlink to Medium. * Fixed commas. * Added hyperlink to Medium where appropriate. * Added period to <li> content for consistency. * Fixed wording so that technical writer description entails writing documentation that explains how a SPECIFIC technology works, rather than how technology in GENERAL works. * Changed wording: guides that tell you how to write web-based CVs (vs) guides on the web that tell you how to write CVs * Made content refer to GDocs files properly. * Deleted erroneous comma (preceded dependent clause). * Inserted 'e.g.' (for example) and 'i.e.' (in other words) where appropriate. * Minor wording changes, plus a typo-fix. * Capitalized 'Fibonacci'; made prompt more mathematically rigorous. * Added more wording changes. * Added in some wording to fill in a gap in sentence, so to speak * Reworded more paragraphs for better flow. * Added more wording changes for better flow. * Reworded for clarity's sake. * Replaced 'I' with 'you' in accordance with OG author's wording. * Replaced dollar-signs with back-ticks. * Removed commas after instances of 'i.e.' and 'e.g.' * Removed commas after instances of 'e.g.' and 'i.e.' * Removed commas after instances of 'e.g.' and 'i.e.' * Removed commas after instances of 'e.g.' and 'i.e.' * Removed commas after instances of 'e.g.' and 'i.e.' * Removed commas after instances of 'e.g.' and 'i.e.' * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Co-authored-by: Chris Mills <[email protected]> * Addded rewording to reduce ambiguity. https://github.com/mdn/content/pull/41489/files/4b48283401a89718f3a1f40349007cf6817ec970..1fc686d9306141ecc3c9ab9bfdba841c112a95eb#diff-81bdf0a00e5a6bf1b9f17ad3528d98f32590d9f092413af1e897036cc71e33f1 * Update files/en-us/learn_web_development/getting_started/soft_skills/finding_a_job/index.md Remove trailing space. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update index.md Reverted this commit, which was sneakily put in without author's consent. 9443fe5 Sorry. * small final tweak * A few more small bits --------- Co-authored-by: Chris Mills <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* css: add object-view-box property page * address review comments
* Move live demo for color-mix() function, change values to parameters * Update files/en-us/web/css/color_value/color-mix/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * add description * nits * values * Apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> * Update files/en-us/web/css/color_value/color-mix/index.md * Update files/en-us/web/css/color_value/color-mix/index.md * Update files/en-us/web/css/color_value/color-mix/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update files/en-us/web/css/color_value/color-mix/index.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * move demo up Updated the description and demo for the `color-mix()` function, enhancing clarity on its usage and importance of color spaces. * Apply suggestions from code review Co-authored-by: Chris Mills <[email protected]> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chris Mills <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )