update examples to use new solara_viz #193
Conversation
examples/aco_tsp/app.py
Outdated
|
|
||
| import networkx as nx | ||
| import solara | ||
| from mesa.visualization.utils import update_counter |
There was a problem hiding this comment.
No, fixed. Currently, normal functions that accept a model and return a solara component automatically update correctly. If annotated with @solara.component you need to call the update counter. This has eventually go into the "author own components" of the viz tutorial
|
Examples that are difficult to update we could move back to the old, now |
Corvince
force-pushed
the
update-solara-viz
branch
from
f69e643 to
bbfcd72
Compare
|
Finally found some time to update the remaining models. There are still a lot of examples that use the old (tornado based) visualizations though. But they are out of scope of this pr |
EwoutH
left a comment
EwoutH
left a comment
There was a problem hiding this comment.
Great work!
I especially like that the agent_portrayal now is a part of a the SpaceDrawer class/component, and you thus can have a portrayal for each drawer. Way more scalable!
|
|
||
| gol = GameOfLifeModel(10, 10) | ||
|
|
||
| AlivePlot = make_plot_measure("Cells alive", "Fraction alive") |
There was a problem hiding this comment.
Does this plot nicely on a single plot? Since "Cells alive" might be on the 0-100 scale, while "Fraction alive" is in the 0-1 scale.
(they are a bit duplicate though, so removing one is also fine)
There was a problem hiding this comment.
not really, I split this into 2 plots
|
|
||
| def space_drawer(model, agent_portrayal): | ||
| @solara.component | ||
| def SpaceDrawer(model): |
There was a problem hiding this comment.
This function is capitalized like a Class. For my own knowlegde, does @solara.component make it Class-like?
There was a problem hiding this comment.
Aren't they all just objects? ;)
As far as I understood this is mostly a convention. It's best to imagine them as neither a class nor a function but as a solara component (because some custom rules apply)
There was a problem hiding this comment.
Just to clarify, since I have looked it up by now. @solara.component does indeed return a regular ´class` object (with a a defined call function, so you can call it like a function). Usually they should still be written in snake_case for standard Python formatting, but thats where the solara convention takes over
WIP to update the models to use the new solaraviz API.
This helps me to write a migration guide for things I notice. So far it goes smoothly, but is a bit tedious