Skip to content

[kommander] feat: add default folder for kommander #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[kommander] feat: add default folder for kommander #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/kommander/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ maintainers:
- name: alejandroEsc
- name: jimmidyson
name: kommander
version: 0.2.27
version: 0.2.28
8 changes: 8 additions & 0 deletions stable/kommander/templates/folder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{{- if .Values.folders.enabled -}}
apiVersion: v1
kind: Namespace
metadata:
name: {{ .Values.folders.default.namespace }}
{{- with .Values.folders.default.annotations }}
{{- with .Values.folders.default.labels }}
{{- end -}}
10 changes: 10 additions & 0 deletions stable/kommander/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,16 @@ grafana:
# hosts:
# - grafana.example.com

folders:
enabled: true
Copy link
Contributor Author

@natmegs natmegs Dec 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this in case we need to feature flag this for some reason, but I think adding the namespace is pretty harmless for now

default:
namespace: kommander-default-folder
labels:
kommanderType: folder
annotations:
kommander.d2iq.io/description: Default folder
kommander.d2iq.io/display-name: Default

## Configure grafana datasources
## ref: http://docs.grafana.org/administration/provisioning/#datasources
##
Expand Down