Skip to content

Fix Gemma inference generation #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kartikayk merged 1 commit into from
Apr 19, 2024
Merged

Fix Gemma inference generation #810

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix Gemma inference
  • Loading branch information
@RefractAI
RefractAI authored Apr 19, 2024
commit 0a12cbe2cca576524b7da4605c030403737c1431
2 changes: 1 addition & 1 deletion torchtune/models/gemma/transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def forward(self, tokens: Tensor, input_pos: Optional[Tensor] = None) -> Tensor:

for layer in self.layers:
# shape: [b, s, d]
h = layer(h, mask, None)
h = layer(h, mask, input_pos)

# shape: [b, s, d]
h = self.norm(h)
Expand Down