Skip to content

Move from Gym 0.22 to Gymnasium 0.28 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuanyiLi merged 16 commits into from
Jun 19, 2023
Merged

Move from Gym 0.22 to Gymnasium 0.28 #445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
f965193
replace gym with gymnasium
pimpale May 14, 2023
57d62d0
go all in on the new termination + truncation semantics
pimpale May 14, 2023
3249fa4
fixed incompatibility between gym and gymnasium
pimpale May 27, 2023
43f5f03
fix some instances of done with terminated and truncated
pimpale May 27, 2023
95ac5c1
continue renaming variables
pimpale May 27, 2023
2f6890e
rewrite more steps
pimpale May 28, 2023
36ffaf8
format
pimpale May 28, 2023
beb0571
fix bugs with obs, pass almost all test cases
pimpale May 29, 2023
694b1f0
fix bugs with test export
pimpale May 29, 2023
caf37ad
fix infinite loop, all test cases pass
pimpale May 29, 2023
e320c06
rename te, tr to tm, tc
pimpale Jun 13, 2023
a121bda
merge fork with upstream
pimpale Jun 13, 2023
72804c7
rename force_seed to seed, introduce gym_wrapper
pimpale Jun 14, 2023
c4df3eb
gate gym behind optional feature, correctly handle when gym is not in…
pimpale Jun 14, 2023
b65cef9
fix test
QuanyiLi Jun 19, 2023
25cd6c6
format code
QuanyiLi Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed incompatibility between gym and gymnasium
  • Loading branch information
@pimpale
pimpale committed May 27, 2023
commit 3249fa4339b467d6daf3ca3c7c9ecbea3237b15e
1 change: 1 addition & 0 deletions metadrive/engine/base_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,7 @@ def process_memory():
cm = lm

for manager_name, manager in self.managers.items():
print(manager)
manager.after_reset()

if _debug_memory_usage:
Expand Down
2 changes: 1 addition & 1 deletion metadrive/manager/agent_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
from metadrive.policy.idm_policy import TrajectoryIDMPOlicy
from typing import Dict

from gym.spaces import Box, Dict, MultiDiscrete, Discrete
from gymnasium.spaces import Box, Dict, MultiDiscrete, Discrete

from metadrive.constants import DEFAULT_AGENT
from metadrive.manager.base_manager import BaseManager
Expand Down