Skip to content

Bump CAPI to v1.5.0 #1268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2023
Merged

Bump CAPI to v1.5.0 #1268

merged 1 commit into from
Aug 17, 2023

Conversation

@Sunnatillo
Copy link
Member

@Sunnatillo Sunnatillo commented Aug 2, 2023 •
edited
Loading

This PR add CAPI v1.5 uplift related changes:

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 2, 2023
@Sunnatillo Sunnatillo force-pushed the bump-capi-v1.5 branch 5 times, most recently from 4ab9b41 to 77071b2 Compare August 3, 2023 10:49
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 3, 2023
@Sunnatillo Sunnatillo force-pushed the bump-capi-v1.5 branch 2 times, most recently from 879791e to f2f1f6c Compare August 3, 2023 19:21
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 3, 2023

/test-ubuntu-integration-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 7, 2023

/keep-test-ubuntu-e2e-integration-main

furkatgofurov7
furkatgofurov7 suggested changes Aug 15, 2023
View reviewed changes
@Sunnatillo Sunnatillo force-pushed the bump-capi-v1.5 branch 2 times, most recently from 1be372f to e7ff694 Compare August 16, 2023 17:01
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 16, 2023

/test-ubuntu-e2e-integration-main
/test-ubuntu-integration-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 16, 2023

/test-ubuntu-e2e-integration-main
/test-ubuntu-integration-main

@Sunnatillo Sunnatillo changed the title WIP: Uplift capi v1.5.0 Bump CAPI to v1.5.0 Aug 16, 2023
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2023
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 16, 2023

/test-centos-integration-release-1-4
/test-ubuntu-integration-main
/test-centos-integration-main
/test-centos-e2e-feature-main
/test-e2e-upgrade-main-from-release-1-4
/test-e2e-1-26-1-27-upgrade-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-centos-e2e-feature-main
/test-centos-integration-release-1-4
/test-ubuntu-e2e-integration-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-centos-integration-release-1-4

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-centos-integration-release-1-4
/test-ubuntu-integration-main
/test-centos-integration-main
/test-centos-e2e-feature-main
/test-e2e-upgrade-main-from-release-1-4
/test-e2e-1-26-1-27-upgrade-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-ubuntu-integration-release-1-4

furkatgofurov7
furkatgofurov7 previously approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2023
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-ubuntu-e2e-integration-main

smoshiur1237
smoshiur1237 reviewed Aug 17, 2023
View reviewed changes
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023 •
edited
Loading

Previously passed tests:
test-centos-integration-main
test-ubuntu-integration-main
test-ubuntu-integration-release-1-4
test-e2e-1-26-1-27-upgrade-main
test-e2e-upgrade-main-from-release-1-4
test-centos-e2e-feature-main

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-centos-integration-release-1-4
/test-ubuntu-e2e-integration-main

smoshiur1237
smoshiur1237 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Looks good to me.
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2023
@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, smoshiur1237

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [furkatgofurov7,smoshiur1237]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/hold
Wait until it gets more reviews

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@mboukhalfa
Copy link
Member

mboukhalfa commented Aug 17, 2023

/lgtm

@mboukhalfa
Copy link
Member

mboukhalfa commented Aug 17, 2023

/test-e2e-upgrade-main-from-release-1-2

@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 17, 2023
@Sunnatillo
Copy link
Member Author

Sunnatillo commented Aug 17, 2023

/test-ubuntu-e2e-integration-main

CI VM did not spin up

@metal3-io-bot metal3-io-bot merged commit a2189c9 into metal3-io:main Aug 17, 2023
@Sunnatillo Sunnatillo deleted the bump-capi-v1.5 branch August 17, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tuminoid tuminoid tuminoid left review comments

+2 more reviewers

@smoshiur1237 smoshiur1237 smoshiur1237 approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Sunnatillo @metal3-io-bot @mboukhalfa @tuminoid @furkatgofurov7 @smoshiur1237