Skip to content

Moving env vars to org #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Moving env vars to org #233

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
38aa8d5
Moving env vars to org
blockiosaurus Jun 10, 2025
bc7b20e
Removing from .env
blockiosaurus Jun 10, 2025
87b2198
Fixing missing export
blockiosaurus Jun 10, 2025
0f6adf4
Adding more env vars
blockiosaurus Jun 11, 2025
1f379df
Always run tests on Dependabot PRs
blockiosaurus Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adding more env vars
  • Loading branch information
@blockiosaurus
blockiosaurus committed Jun 11, 2025
commit 0f6adf4f4882a85dafccd3d156eb65063b148a7a
3 changes: 0 additions & 3 deletions .github/.env
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
CARGO_TERM_COLOR=always
PROGRAMS=["mpl-core"]
RUST_VERSION=1.79.0
SOLANA_VERSION=1.18.19
COMMIT_USER_NAME=github-actions
[email protected]
DEPLOY_SOLANA_VERSION=1.18.19
4 changes: 3 additions & 1 deletion .github/workflows/benchmark-summary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:
uses: actions/checkout@v4

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/build-programs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/build-rust-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/deploy-program.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,10 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "DEPLOY_SOLANA_VERSION=${{ vars.DEPLOY_SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ jobs:
uses: actions/checkout@v4

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/publish-rust-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ jobs:
uses: actions/checkout@v4

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand All @@ -84,8 +86,8 @@ jobs:

if [ "${{ inputs.dry_run }}" == "false" ]; then
OPTIONS="--no-push --no-tag --no-confirm --execute"
git config user.name ${{ env.COMMIT_USER_NAME }}
git config user.email ${{ env.COMMIT_USER_EMAIL }}
git config user.name ${{ vars.COMMIT_USER_NAME }}
git config user.email ${{ vars.COMMIT_USER_EMAIL }}
fi
Comment on lines +89 to 91
Copy link

@coderabbitai coderabbitai bot Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Quote Git config values to handle spaces.

Wrap the user name/email expansions in quotes to avoid splitting on spaces:

- git config user.name ${{ vars.COMMIT_USER_NAME }}
+ git config user.name "${{ vars.COMMIT_USER_NAME }}"
- git config user.email ${{ vars.COMMIT_USER_EMAIL }}
+ git config user.email "${{ vars.COMMIT_USER_EMAIL }}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
git config user.name ${{ vars.COMMIT_USER_NAME }}
git config user.email ${{ vars.COMMIT_USER_EMAIL }}
fi
git config user.name "${{ vars.COMMIT_USER_NAME }}"
git config user.email "${{ vars.COMMIT_USER_EMAIL }}"
fi
🤖 Prompt for AI Agents 
In .github/workflows/publish-rust-client.yml around lines 89 to 91, the git
config commands for user.name and user.email do not quote the variable
expansions, which can cause issues if the values contain spaces. Fix this by
wrapping the variable expansions ${{ vars.COMMIT_USER_NAME }} and ${{
vars.COMMIT_USER_EMAIL }} in double quotes to ensure the entire value is treated
as a single argument.


echo "Cargo logging in"
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/test-js-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down Expand Up @@ -70,7 +72,9 @@ jobs:
uses: actions/checkout@v4

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-programs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,10 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/test-rust-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ jobs:
ref: ${{ inputs.git_ref }}

- name: Export GitHub vars to GITHUB_ENV
run: echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
run: |
echo "NODE_VERSION=${{ vars.NODE_VERSION }}" >> $GITHUB_ENV
echo "RUST_VERSION=${{ vars.RUST_VERSION }}" >> $GITHUB_ENV
echo "SOLANA_VERSION=${{ vars.SOLANA_VERSION }}" >> $GITHUB_ENV

- name: Load environment variables
run: cat .github/.env >> $GITHUB_ENV
Expand Down