-
Notifications
You must be signed in to change notification settings - Fork 1k
Process add'l data on registration #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
apps-caraga
wants to merge
14
commits into
mevdschee:main
Choose a base branch
from
apps-caraga:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1ee817f
Registration w/ addl data
apps-caraga 0f4e2b9
Minor formatting update
apps-caraga 045819c
Merge pull request #1 from apps-caraga/apps-caraga-patch-2
apps-caraga 57a761f
Updated readme (Add'l dbAuth properties)
apps-caraga d5c63a6
Added workaround for duplicate key error
apps-caraga 5a447da
Merge branch 'mevdschee:main' into main
apps-caraga c86eaf3
Refresh session data via /me endpoint
apps-caraga 17e30fe
Option to update session data via /me end-point
apps-caraga f7061de
Merge pull request #2 from apps-caraga/apps-caraga-patch-2
apps-caraga 372e36f
Merge branch 'mevdschee:main' into main
apps-caraga a72fd8d
Update DbAuthMiddleware.php
apps-caraga 2c20589
Merge branch 'mevdschee:main' into main
apps-caraga 588811e
Merge branch 'mevdschee:main' into main
apps-caraga 3c2c472
Update Api.php
apps-caraga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added workaround for duplicate key error
Since we're processing additional data during registration, we need to check if these data were defined in db to be unique. For example, email addresses are usually used just once in an application. We can query the database to check if the new email address is not yet registered, but, in some cases, we may more than 2 or 3 or more unique fields (not common, but possible), hence we would also need to query 2,3 or more times. As a TEMPORARY WORKAROUND, we'll just attempt to register the new user and wait for the db to throw a DUPLICATE KEY EXCEPTION.
- Loading branch information
commit d5c63a6b1ecdb15025c29e04f21a75cca2d3222c
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.