Add CA1507/MA0043 equivalent rule mapping #870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added CA1507 (Use nameof in place of string) to equivalent rules table - Maps to MA0043 (Use nameof operator in ArgumentException) - CA1507 has broader coverage than MA0043, including ArgumentException scenarios Closes meziantou#847
Contributor
Author
|
closed in favor of #871 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the equivalent rule mapping between CA1507 and MA0043 to the comparison documentation.
Changes
Analysis
Both rules serve the same purpose: detecting hardcoded string literals that could be replaced with the
nameofoperator for better maintainability and compile-time safety.CA1507 has broader coverage than MA0043:
nameofopportunities in any method parameter namedparamNameor property namedpropertyNameRecommendation
Since CA1507 covers all functionality of MA0043 and more, teams should use the official Microsoft analyzer rule CA1507 instead of MA0043.
Closes #847