Enhance MA0048 diagnostic messages with type information #873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update diagnostic message format to include type kind and name - Add GetTypeKindDisplayString method to detect and display appropriate type kinds - Support class, struct, enum, interface, record, record struct, and delegate types - Add comprehensive test cases for all supported type kinds - Update documentation with examples of new message format Closes meziantou#872
Contributor
Author
|
created this using two github-copilot prompts and for the PR used the github remote MCP server |
meziantou
reviewed
Sep 14, 2025
src/Meziantou.Analyzer/Rules/FileNameMustMatchTypeNameAnalyzer.cs
Outdated
Show resolved
Hide resolved
meziantou
reviewed
Sep 14, 2025
Add conditional compilation directives (#if ROSLYN_4_2_OR_GREATER) around IsRecord property usage in GetTypeKindDisplayString method to support older Roslyn versions that don't have this property. Fixes compilation errors in CI pipeline for Roslyn 3.8 target.
This was referenced Sep 19, 2025
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Sep 19, 2025
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 2.0.219 to 2.0.220. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 2.0.220 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.220> ## What's Changed * docs: Add multiple CA/MA analyzer rule mappings by @Meir017 in meziantou/Meziantou.Analyzer#871 * Enhance MA0048 diagnostic messages with type information by @Meir017 in meziantou/Meziantou.Analyzer#873 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.219...2.0.220 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@2.0.219...2.0.220). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Sep 19, 2025
Closed
Bump Meziantou.Analyzer from 2.0.203 to 2.0.220
Analogy-LogViewer/Analogy.AspNetCore.LogProvider#340
Closed
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
This was referenced Dec 10, 2025
Open
This was referenced Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the MA0048 analyzer to provide more informative diagnostic messages that include the type kind and name.
Changes
"File name must match type name"to"File name must match type name ({type-kind} {type-name})"GetTypeKindDisplayString()method that identifies different type kinds:class- for regular classesstruct- for value typesenum- for enumerationsinterface- for interfacesrecord- for record classesrecord struct- for record structsdelegate- for delegate typesMA0048.mdwith examples of the new message formatExamples
Before:
After:
Testing
All 42 existing tests continue to pass, plus 6 new tests specifically validate the enhanced message format for each type kind.
Closes #872