docs: enhance MA0090 and MA0098 rule documentation #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- MA0090: Add comprehensive documentation for 'Remove empty else/finally block' rule - Include detailed rule description and rationale - Add code examples for both else and finally blocks - Document exceptions and edge cases (comments, preprocessor directives) - Add configuration options and severity settings - Include additional resources and best practices - MA0098: Update documentation for 'Use indexer instead of LINQ methods' rule - Enhanced examples and performance guidance - Clarified when rule applies and exceptions - Added related rules section
meziantou
reviewed
Sep 14, 2025
- Replace verbose separate sections with concise inline examples - Use 'non-compliant' and 'compliant' terminology consistently - Follow established documentation pattern used in other rules - Address comment meziantou#874 (comment)
Remove comprehensive Related Rules section to maintain consistency with existing documentation pattern used across all other analyzer rules. Address comment meziantou#874 (comment)
- Replace verbose section headers with inline comments - Use standard 'non-compliant'/'compliant' format - Consolidate examples into single code block - Address PR review feedback for structural consistency
meziantou
approved these changes
Sep 27, 2025
This was referenced Sep 30, 2025
IhateTrains
pushed a commit
to ParadoxGameConverters/ImperatorToCK3
that referenced
this pull request
Oct 1, 2025
Updated [Meziantou.Analyzer](https://github.com/meziantou/Meziantou.Analyzer) from 2.0.221 to 2.0.222. <details> <summary>Release notes</summary> _Sourced from [Meziantou.Analyzer's releases](https://github.com/meziantou/Meziantou.Analyzer/releases)._ ## 2.0.222 NuGet package: <https://www.nuget.org/packages/Meziantou.Analyzer/2.0.222> ## What's Changed * docs: enhance MA0090 and MA0098 rule documentation by @Meir017 in meziantou/Meziantou.Analyzer#874 * MA0042 fixer creates generic method call if generic method was called by @Griboedoff in meziantou/Meziantou.Analyzer#881 ## New Contributors * @Griboedoff made their first contribution in meziantou/Meziantou.Analyzer#881 **Full Changelog**: meziantou/Meziantou.Analyzer@2.0.221...2.0.222 Commits viewable in [compare view](meziantou/Meziantou.Analyzer@2.0.221...2.0.222). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 1, 2025
This was referenced Dec 3, 2025
Closed
This was referenced Dec 10, 2025
Open
This was referenced Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MA0090: Add comprehensive documentation for 'Remove empty else/finally block' rule
MA0098: Update documentation for 'Use indexer instead of LINQ methods' rule