Skip to content

Add MA0178: Use TimeSpan.Zero instead of TimeSpan.FromXXX(0) #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meziantou merged 9 commits into from
Nov 18, 2025
Merged

Add MA0178: Use TimeSpan.Zero instead of TimeSpan.FromXXX(0) #929

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1206ae7
Initial plan
Copilot Nov 18, 2025
024bc3d
Add MA0178: Use TimeSpan.Zero instead of TimeSpan.FromXXX(0)
Copilot Nov 18, 2025
6849e2d
Add comprehensive documentation for MA0178
Copilot Nov 18, 2025
6cbadef
Extract IsZero into NumericHelpers and reuse in both analyzers
Copilot Nov 18, 2025
15fa55a
Fix documentation - add missing newline at end of file
Copilot Nov 18, 2025
aa4db9f
Add missing using Xunit directive in test file
Copilot Nov 18, 2025
74eeeb2
Update TimeSpan usage to include System namespace
meziantou Nov 18, 2025
933d6fc
Check TimeSpan type exists before registering code fix
Copilot Nov 18, 2025
32fab0a
Fix tests
meziantou Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update TimeSpan usage to include System namespace
  • Loading branch information
@meziantou
meziantou authored Nov 18, 2025
commit 74eeeb2dbb2f30c821861e8e4fff7a2a64a15c8e
58 changes: 29 additions & 29 deletions tests/Meziantou.Analyzer.Test/Rules/UseTimeSpanZeroAnalyzerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ private static ProjectBuilder CreateProjectBuilder()
}

[Theory]
[InlineData("TimeSpan.FromSeconds(0)")]
[InlineData("TimeSpan.FromSeconds(0.0)")]
[InlineData("TimeSpan.FromMinutes(0)")]
[InlineData("TimeSpan.FromMinutes(0.0)")]
[InlineData("TimeSpan.FromHours(0)")]
[InlineData("TimeSpan.FromHours(0.0)")]
[InlineData("TimeSpan.FromDays(0)")]
[InlineData("TimeSpan.FromDays(0.0)")]
[InlineData("TimeSpan.FromMilliseconds(0)")]
[InlineData("TimeSpan.FromMilliseconds(0.0)")]
[InlineData("TimeSpan.FromMicroseconds(0)")]
[InlineData("TimeSpan.FromMicroseconds(0.0)")]
[InlineData("TimeSpan.FromTicks(0)")]
[InlineData("TimeSpan.FromTicks(0L)")]
[InlineData("System.TimeSpan.FromSeconds(0)")]
[InlineData("System.TimeSpan.FromSeconds(0.0)")]
[InlineData("System.TimeSpan.FromMinutes(0)")]
[InlineData("System.TimeSpan.FromMinutes(0.0)")]
[InlineData("System.TimeSpan.FromHours(0)")]
[InlineData("System.TimeSpan.FromHours(0.0)")]
[InlineData("System.TimeSpan.FromDays(0)")]
[InlineData("System.TimeSpan.FromDays(0.0)")]
[InlineData("System.TimeSpan.FromMilliseconds(0)")]
[InlineData("System.TimeSpan.FromMilliseconds(0.0)")]
[InlineData("System.TimeSpan.FromMicroseconds(0)")]
[InlineData("System.TimeSpan.FromMicroseconds(0.0)")]
[InlineData("System.TimeSpan.FromTicks(0)")]
[InlineData("System.TimeSpan.FromTicks(0L)")]
[InlineData("System.TimeSpan.FromSeconds(0)")]
public async Task ShouldReportDiagnostic(string code)
{
Expand All @@ -54,18 +54,18 @@ void Test()
}

[Theory]
[InlineData("TimeSpan.FromSeconds(1)")]
[InlineData("TimeSpan.FromSeconds(0.5)")]
[InlineData("TimeSpan.FromMinutes(1)")]
[InlineData("TimeSpan.FromHours(1)")]
[InlineData("TimeSpan.FromDays(1)")]
[InlineData("TimeSpan.FromMilliseconds(100)")]
[InlineData("TimeSpan.FromMicroseconds(1)")]
[InlineData("TimeSpan.FromTicks(1)")]
[InlineData("TimeSpan.Zero")]
[InlineData("new TimeSpan()")]
[InlineData("new TimeSpan(0)")]
[InlineData("default(TimeSpan)")]
[InlineData("System.TimeSpan.FromSeconds(1)")]
[InlineData("System.TimeSpan.FromSeconds(0.5)")]
[InlineData("System.TimeSpan.FromMinutes(1)")]
[InlineData("System.TimeSpan.FromHours(1)")]
[InlineData("System.TimeSpan.FromDays(1)")]
[InlineData("System.TimeSpan.FromMilliseconds(100)")]
[InlineData("System.TimeSpan.FromMicroseconds(1)")]
[InlineData("System.TimeSpan.FromTicks(1)")]
[InlineData("System.TimeSpan.Zero")]
[InlineData("new System.TimeSpan()")]
[InlineData("new System.TimeSpan(0)")]
[InlineData("default(System.TimeSpan)")]
public async Task ShouldNotReportDiagnostic(string code)
{
await CreateProjectBuilder()
Expand All @@ -90,9 +90,9 @@ class TestClass
{
void Test()
{
_ = [||]TimeSpan.FromSeconds(0);
_ = [||]TimeSpan.FromMinutes(0);
_ = [||]TimeSpan.FromHours(0);
_ = [||]System.TimeSpan.FromSeconds(0);
_ = [||]System.TimeSpan.FromMinutes(0);
_ = [||]System.TimeSpan.FromHours(0);
}
}
""")
Expand Down
Loading