Systematically use relative_url filter for links #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to deploy with a base URL which is helpful for preview deployments. It's not ideal but it's a pragmatic way to sort out our review deployment setup. This also upgrades Jekyll to the latest 3.x for relative_url support. Note if you don't install the latest it just silently fails to work.
|
Needs to be merged in coordination with a tech site PR. |
|
One downside of this change is that GitHub no longer renders the links as links in its rich markdown diffs/file previews. However, they never did actually work as links (as they don't reference the markdown but the permalink) so I don't think this is so bad. Ideally we'd use a SSG that lets us link to .md files in the natural way and have the correct website URLs emitted at build time - one to consider in future. |
microbit-robert
requested changes
Sep 4, 2025
Co-authored-by: Robert Knight <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to deploy with a base URL which is helpful for preview deployments. It's not ideal but it's a pragmatic way to sort out our review deployment setup.
This requires Jekyll to be upgraded to the latest 3.x for relative_url support. Note if you don't install the latest it just silently fails to work.