[DO NOT MERGE] Remove usb visibilityChangeListener
#40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview Url won't work for WebUSB with radio bridge connection because you need to hardcode the remote device id Deploying microbit-connection with
|
| Latest commit: |
d22d72f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7871f66d.microbit-connection.pages.dev |
| Branch Preview URL: | https://tab-change.microbit-connection.pages.dev |
microbit-grace
commented
Nov 8, 2024
| - run: npm run ci | ||
| - run: npm publish | ||
| if: github.event_name == 'release' && github.event.action == 'created' | ||
| # if: github.event_name == 'release' && github.event.action == 'created' |
There was a problem hiding this comment.
Uncomment this line if merging
microbit-grace
changed the title
visibilityChangeListener
|
No longer needed. visibilityChangeListener is needed since beforeUnloadListener may not run the async process reliably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimentation: Removing
visibilityChangeListenerWhat I have learnt
beforeUnloadListeneris necessary for fixing this issue: "Bad response for 8 -> 17" bug related to use of serial python-editor-v3#89. It importantly stopSerialInternal, but this may not run reliably since it is async