codal_port/modspeech: include mphal.h for the simulator #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MICROPY_BEGIN_ATOMIC_SECTION/MICROPY_END_ATOMIC_SECTION are only defined in modspeech because of mpconfigport.h (indirectly). Include mphal.h so that the defaults are defined if the port does not define them (as in the sim case).
|
You can see the sim compile error that motivated this here: https://github.com/microbit-foundation/micropython-microbit-v2-simulator/actions/runs/8376957819/job/22937869589 (though that branch is based on audio-recording so we can explore the sim work for that). |
|
Thanks, this is the correct change. It's needed because of the recent update to MicroPython v1.22.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MICROPY_BEGIN_ATOMIC_SECTION/MICROPY_END_ATOMIC_SECTION are only defined in modspeech because of mpconfigport.h (indirectly). Include mphal.h so that the defaults are defined if the port does not define them (as in the sim case).