Update P9 to be UNUSED on V2 (was shared on V1) #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I tested this. When you do Let me know if you want me to make the change. |
P9 is a spare pin on micro:bit V2, but was shared with the display on V1 This commit updates the definition of the pin and stops the display from trying to acquire/release it during enable/disable Full pinout is available https://tech.microbit.org/hardware/edgeconnector/ See #57
jaustin
force-pushed
the
P9-usage-fixup
branch
from
45025e6 to
a0f7ca3
Compare
|
Should've grepped-before-PR sorry. Serves me right for trying to use the web interface to fix bugs. I've made the change and pushed. Will test the CI build when it's ready. @dpgeorge in general you should feel free to just fix and commit things like this of mine if you're already in the right place etc. (Also fine to ask me to fix it, useful to see what I'd missed :) ) |
|
I tested this PR and it works. Merged in a94e53d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
P9 is a spare pin on micro:bit V2, but was shared with the display on V1
Full pinout is available https://tech.microbit.org/hardware/edgeconnector/
See #57