Vending: Expand payment methods#2881
Merged
mar-v-in merged 1 commit intomicrog:masterfrom Jul 11, 2025
Merged
Conversation
DaVinci9196
added a commit
to DaVinci9196/GmsCore
that referenced
this pull request
Jul 17, 2025
Add multi-window support in the billing webview. This allows to use or set-up additional payment methods like PayPal that need to launch a popup window.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expand other payment methods based on the internal webview loading method.
1: The main interface for adding payment methods must support multi-window mode. Otherwise, an exception will be thrown when window.open is executed inside the web page, causing the registration data transfer method to fail.
2: Clicking Continue on the main page will redirect and execute to onCreateWindow in WebChromeClient, where a new webview is created to carry the directed page. Displaying the new webview in a dialog created based on the main page context can return data to the main page after the operation.
3: Currently the test can bind the PayPal payment method normally.