Skip to content

DynamicLink: Optimized the code #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mar-v-in merged 5 commits into from
Jul 13, 2025
Merged

DynamicLink: Optimized the code #2908

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3acdca9
DynamicLink: Added file link processing
DaVinci9196 May 13, 2025
89fdb0e
DynamicLink: Added file link processing
DaVinci9196 May 13, 2025
5427263
Optimizing the code
DaVinci9196 Jun 18, 2025
33b4f0e
cleancode
DaVinci9196 Jul 12, 2025
d5b3e47
Remove unused import
mar-v-in Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 29 additions & 30 deletions ...services-core/src/main/kotlin/org/microg/gms/firebase/dynamiclinks/DynamicLinksService.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import android.content.Context
import android.net.Uri
import android.os.Bundle
import android.os.Parcel
import android.text.TextUtils
import android.util.Log
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.LifecycleOwner
Expand Down Expand Up @@ -50,42 +51,40 @@ class DynamicLinksServiceImpl(private val context: Context, private val callingP

override fun getDynamicLink(callback: IDynamicLinksCallbacks, link: String?) {
Log.d(TAG, "getDynamicLink: callingPackageName: $callingPackageName link: $link")
if (link != null) {
val linkUri = Uri.parse(link)
if ("http" == linkUri.scheme || "https" == linkUri.scheme) {
lifecycleScope.launchWhenCreated {
lifecycleScope.launchWhenCreated {
try {
if (link == null) {
throw RuntimeException("Missing link")
}
val linkUri = Uri.parse(link)
if ("http" == linkUri.scheme || "https" == linkUri.scheme) {
val response = runCatching { withContext(Dispatchers.IO) { DynamicLinkUtils.requestLinkResponse(link, queue) } }.getOrNull()
val data = if (response == null) {
DynamicLinkData(null, link, 0, 0, null, null)
} else {
DynamicLinkData(
response.metadata?.info?.url, response.data_?.intentData, (response.data_?.app?.minAppVersion ?: 0).toInt(), System.currentTimeMillis(), null, null
)
?: throw RuntimeException("requestLinkResponse failed")
val data = DynamicLinkData(link, response.data_?.intentData, (response.data_?.app?.minAppVersion ?: 0).toInt(), System.currentTimeMillis(), null, null)
Log.d(TAG, "getDynamicLink: $link -> $data")
callback.onStatusDynamicLinkData(Status.SUCCESS, data)
return@launchWhenCreated
}
val deepLink = linkUri.getQueryParameter("link")
if (!deepLink.isNullOrEmpty()) {
val packageName = linkUri.getQueryParameter("apn")
val amvParameter = linkUri.getQueryParameter("amv")
if (packageName == null) {
throw RuntimeException("Missing package name")
} else if (callingPackageName != packageName) {
throw RuntimeException("Registered package name:$callingPackageName does not match link package name: $packageName")
}
var amv = amvParameter?.takeIf { it !== "" }?.toInt() ?: 0
val data = DynamicLinkData(link, deepLink, amv, 0, null, null)
Log.d(TAG, "getDynamicLink: $link -> $data")
callback.onStatusDynamicLinkData(Status.SUCCESS, data)
return@launchWhenCreated
}
return
}
val packageName = linkUri.getQueryParameter("apn")
val amvParameter = linkUri.getQueryParameter("amv")
if (packageName == null) {
throw RuntimeException("Missing package name")
} else if (callingPackageName != packageName) {
throw RuntimeException("Registered package name:$callingPackageName does not match link package name: $packageName")
}
var amv = 0
if (amvParameter != null && amvParameter !== "") {
amv = amvParameter.toInt()
throw RuntimeException("$link is not a valid dynamic link")
} catch (e: Exception) {
Log.d(TAG, "getDynamicLink: error : ${e.message}")
callback.onStatusDynamicLinkData(Status.SUCCESS, null)
}
val data = DynamicLinkData(
null, linkUri.getQueryParameter("link"), amv, 0, null, null
)
Log.d(TAG, "getDynamicLink: $link -> $data")
callback.onStatusDynamicLinkData(Status.SUCCESS, data)
} else {
Log.d(TAG, "getDynamicLink: " + null + " -> " + null)
callback.onStatusDynamicLinkData(Status.SUCCESS, null)
}
}

Expand Down