Fix touchstart from triggering underlying elements #479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codefund.app is no longer active and this opening tab is annoying during development
this was triggering any underlying elements
Collaborator
|
@ghosh - Seems like many user's are waiting for this fix. Please review it and help me to get it merged. |
kalpeshsingh
approved these changes
Nov 3, 2021
Collaborator
kalpeshsingh
left a comment
kalpeshsingh
left a comment
There was a problem hiding this comment.
Looks good to me.
Thanks for your contribution @bgoewert. 🙌
ghosh
approved these changes
Nov 23, 2021
This was referenced Nov 23, 2021
simonewebdesign
added a commit
to simonewebdesign/Micromodal
that referenced
this pull request
Nov 24, 2021
This was causing an error:
Unable to preventDefault inside passive event listener invocation.
Essentially reverts micromodal#478.
Related to micromodal#475, micromodal#477, micromodal#479
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #477
Also removed the codefund embed as Codefund has been shutdown since July 14 per their twitter bio.