Skip to content

Conversation

@lmolkova
Copy link

@lmolkova lmolkova commented Nov 14, 2022

Addressing portal team feedback on new Cosmos instrumentation:

  • in Direct (TCP mode), Cosmos will set Client kind on activities. Even though Cosmos uses TCP, some rare HTTP requests will be made under these activities, so there will be a few occasional client->client spans.
  • In Gateway (HTTP mode), Cosmos will set Internal kind on activities. Users are expected to get both internal (logical) activities and nested HTTP calls.

@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1a58e53 to 1d4bbd6 Compare November 16, 2022 01:12
@lmolkova lmolkova force-pushed the cosmos-internal-client-suppress-nested-http branch from 1d4bbd6 to 5b62194 Compare January 11, 2023 01:50
Copy link

@sourabh1007 sourabh1007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a changelog entry.

@lmolkova
Copy link
Author

LGTM with a changelog entry.

thank you @reyang! I updated the changelog.

@TimothyMothra TimothyMothra merged commit 18be714 into microsoft:main Feb 1, 2023
@lmolkova
Copy link
Author

lmolkova commented Feb 1, 2023

thank you @TimothyMothra !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants